Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update failing tests #732

Merged
merged 5 commits into from
Apr 1, 2024
Merged

chore: update failing tests #732

merged 5 commits into from
Apr 1, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Mar 28, 2024

Fixes some failing tests.

Some of these are due to the recent changes to automatically add targeting keys.

@liran2000
Copy link
Member

@toddbaert please see #722 first

@toddbaert
Copy link
Member Author

@liran2000 Oh, very sorry I missed this. I will take a look.

@toddbaert toddbaert marked this pull request as draft March 28, 2024 20:52
@toddbaert toddbaert marked this pull request as ready for review April 1, 2024 12:34
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
Copy link
Member Author

@liran2000 Oh, very sorry I missed this. I will take a look.

@liran2000 I merged the referenced request. It did take care of all the statsig issues. This fixes a remaining one in configcat, and makes some test vars private.

@toddbaert toddbaert merged commit e1eaf4e into main Apr 1, 2024
4 checks passed
@toddbaert toddbaert deleted the chore/fix-tests branch April 1, 2024 17:24
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…t to ba1c241 (open-feature#732)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants